Create a record class for the build constants - #59
Merged
Conversation
kcooney
force-pushed
the
kcooney/build-constants-record
branch
from
September 7, 2025 19:22
ab25f50 to
d61188c
Compare
kcooney
force-pushed
the
kcooney/build-constants-record
branch
2 times, most recently
from
September 20, 2025 01:08
400d969 to
1905d1c
Compare
Motivation - Makes the core code easier to understand (by centralizing the fields and reflection code) - Provides a path that could allow us to migrate our use of gversion to generate a properties file instead of a Java class (which would be much allow simpler extraction code)
…so it doesn't get stale)
kcooney
force-pushed
the
kcooney/build-constants-record
branch
from
September 23, 2025 01:35
1905d1c to
b7ea2c1
Compare
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 24, 2025
kcooney
added a commit
to Prospect-Robotics/Robot2025
that referenced
this pull request
Sep 25, 2025
This includes the following: - Prospect-Robotics/lib2813#54 - Prospect-Robotics/lib2813#55 - Prospect-Robotics/lib2813#56 - Prospect-Robotics/lib2813#58 - Prospect-Robotics/lib2813#59 - Prospect-Robotics/lib2813#60 Local changes: - Remove now-redundant overrides of `MotorSubsystem.getAppliedCurrent()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
reflection code)
generate a properties file instead of a Java class (which would be much
allow simpler extraction code)
Also update BuildConstantsPublisher JavaDoc to reference the WPILib docs
(so it doesn't get stale).